Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image carousel #23

Open
lbelmore opened this issue Feb 15, 2019 · 1 comment
Open

Image carousel #23

lbelmore opened this issue Feb 15, 2019 · 1 comment
Assignees
@NataliaProtasova @Tom-Preston

Comments

@lbelmore
Copy link
Contributor

@Tom-Preston - can you add the links for the updated image carousel here
@lbelmore
Copy link
Contributor Author

File used to isolate Gallery item in progress by Natalia
https://hc-sc.github.io/rsa-renewal/examples/Carousel_Natalia_edit.html

And adding the comments from Miguel here are well ...

For the image slider - great work on updating it, but it still needs work to be mobile friendly:

  • adding some kind of touch area around the next and backward arrows (option 1 would be a shaded bar all along the height of the frame, option 2 would be a shaded circle around the arrow)
  • adding some kind of visual indication that there is a next and previous, and that it is swipeable. This was previously done with the main image shrunk within the frame and the borders of the next and previous images. If this isn't possible, The material.io style guide has some guidance on gestures and affordances that might be of interest: https://material.io/design/interaction/gestures.html#properties

@NataliaProtasova - let's connect and go over the next steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NataliaProtasova NataliaProtasova

@Tom-Preston Tom-Preston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NataliaProtasova @lbelmore @Tom-Preston