Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create deletions endpoint #1795

Open
dr0i opened this issue Jun 15, 2023 · 3 comments
Open

Create deletions endpoint #1795

dr0i opened this issue Jun 15, 2023 · 3 comments
Assignees
Labels

Comments

@dr0i
Copy link
Member

dr0i commented Jun 15, 2023

Reported by F.F.:

Since we switched to ALMA as primary source database we have to build a deletions endpoint based on ALMA.

This should work:
http://lobid.org/resources/deletions/search?q=describedBy.deleted%3A%5B20230528+TO+20230605%5D and yield some results.

See http://lobid.org/resources/api "Löschungen zwischen zwei Zeitpunkten".

See cba6a49 as a pointer of how to build this deletions index.

@dr0i dr0i changed the title Remove deletions endpoint Create deletions endpoint Jun 15, 2023
@dr0i dr0i added the ALMA label Jun 15, 2023
@dr0i dr0i self-assigned this Jun 15, 2023
@dr0i
Copy link
Member Author

dr0i commented Jun 15, 2023

As discussed offline with @TobiasNx and @acka47 : we could just not skip the deletions (see #1794) but rather update these records in the same lobid-resources-index and mark them "deleted". Then one could query that.
Note than that we won't have a history of deleted resources. We will just have a weekly basedump , reflecting all deletions older that one week, plus deleted resources marked as deleted from within that week.

@dr0i dr0i removed their assignment Jun 16, 2023
@TobiasNx
Copy link
Contributor

TobiasNx commented Jul 4, 2023

Also we could index the deleted records in an additional index too, which is not overwriten weekly but new deletions are added to keep the history.

@dr0i
Copy link
Member Author

dr0i commented Jul 4, 2023

Also we could index the deleted records in an additional index too, which is not overwriten weekly but new deletions are added to keep the history

ACK - but that implies a bit more work and potentially more maintenance. We could do that if it's asked for, though,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants