Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hydra properties to context #252

Open
acka47 opened this issue Feb 11, 2020 · 3 comments
Open

Add Hydra properties to context #252

acka47 opened this issue Feb 11, 2020 · 3 comments
Assignees
Labels
upstream changes in upstream data/API needed

Comments

@acka47
Copy link
Contributor

acka47 commented Feb 11, 2020

This is missing in https://lobid.org/gnd/context.jsonld (used in search result lists and already added in /organisations):

{
   "totalItems":"http://www.w3.org/ns/hydra/core#totalItems",
   "member":{
      "@type":"@id",
      "@id":"http://www.w3.org/ns/hydra/core#member"
   }
}
@fsteeg
Copy link
Member

fsteeg commented Mar 6, 2020

Deployed to test: https://test.lobid.org/gnd/context.jsonld

But there's a problem: we already have a member key.

"member": {
  "@id": "https://d-nb.info/standards/elementset/gnd#member",
  "@type": "@id",
  "@container": "@set"
}

@fsteeg fsteeg assigned acka47 and unassigned fsteeg Mar 6, 2020
@acka47
Copy link
Contributor Author

acka47 commented Mar 9, 2020

The member key currently is not used in lobid-gnd: https://lobid.org/gnd/search?q=_exists_%3Amember

It looks like it was rather added to the gnd ontology as a structural element. It has three subproperties from which at least two are used: https://lobid.org/gnd/search?q=_exists_%3AcorporateBodyIsMember+OR+_exists_%3AmemberOfTheFamily+OR+_exists_%3AplaceOrGeographicNameIsMember

Thus, I suggest to change the key for gnd:member in the context (probably best do isMemberOf) and add the hydra property being mapped to member. I will add the according commit.

@acka47
Copy link
Contributor Author

acka47 commented Mar 9, 2020

This getting more and more out of hand. When I tried out to update the key for gndo:member I noticed that it is unclear how member is supposed to be used as its two subproperties that are in used model the exact opposite relations. I made an issue at the GND jira (https://jira.dnb.de/browse/GND-136), here is what I wrote:

Inkonsistente Verwendung von gndo:member Subpropoerties

In der GND Ontology hat die member-Property drei Unterproperties: corporateBodyIsMember, memberOfTheFamily, placeOrGeographicNameIsMember. Nur die ersten beiden werden bisher verwendet und zwar in ca. 2500 Einträgen, siehe https://lobid.org/gnd/search?q=_exists_%3AcorporateBodyIsMember+OR+_exists_%3AmemberOfTheFamily.

Leider ist die Verwendung inkonsistent. Während corporateBodyIsMember von einer Körperschaft auf andere Körperschaften verweist, die Mitglied in ersterer sind (vgl. https://lobid.org/gnd/search?q=_exists_%3AcorporateBodyIsMember&size=100&format=html), wird memberOfTheFamily verwendet, um von einer Person auf die Familie zu verweisen, in der sie Mitglied ist.

Das heißt das eine mal geht der Link vom Mitglied zur Gruppe, das andere Mal in die andere Richtung. Wenn ich mir die Ontologie so anschaue, scheint die Verwendung bei Personen (vom Mitglied zur Gruppe) die intendierte zu sein.

In MARC sind die Infos in 500 (Person) bzw. 510 (Körperschaften) und die Relation heißt beide Male in Unterfeld i "Mitglied", beschreibt aber tatsächlich die jeweils entgegengesetzte Beziehung.

@acka47 acka47 added the upstream changes in upstream data/API needed label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream changes in upstream data/API needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants