Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): add permanent placeholder story and fix styling issue #526

Merged
merged 3 commits into from
Nov 10, 2023
Merged

fix(ui): add permanent placeholder story and fix styling issue #526

merged 3 commits into from
Nov 10, 2023

Conversation

emrberk
Copy link
Contributor

@emrberk emrberk commented Nov 9, 2023

  • Storybook item is added for permanent placeholder
  • New screenshots generated
  • Fixed the misplaced css selector

@Sodik
Copy link
Collaborator

Sodik commented Nov 9, 2023

I would make it more universal. Two properties (placeholder and placeholderMode) instead of one.

@emrberk
Copy link
Contributor Author

emrberk commented Nov 9, 2023

I would make it more universal. Two properties (placeholder and placeholderMode) instead of one.

Good idea, can you please take a look at it again?

@Sodik Sodik self-requested a review November 10, 2023 06:31
@emrberk emrberk merged commit 65e673e into master Nov 10, 2023
3 checks passed
@emrberk emrberk deleted the fix/permanentPlaceholder branch November 10, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matochu matochu matochu approved these changes

@Sodik Sodik Sodik approved these changes

@fantkolja fantkolja fantkolja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emrberk @Sodik @matochu @fantkolja