Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of <Link> component #495

Open
utkukaratas opened this issue May 22, 2023 · 1 comment
Open

Get rid of <Link> component #495

utkukaratas opened this issue May 22, 2023 · 1 comment

Comments

@utkukaratas
Copy link
Contributor

in MC we have abstracted on this so much it made things unbearably complex. come to think of it here're some reasons to get rid of it:

  • pretty much any routing library / meta react framework has its own Link component.
  • it provides nothing specially useful.
  • links are rendered in a variety of ways depending on your app so even a common style is not really helpful.
@fantkolja
Copy link
Collaborator

@utkukaratas But in our case we use it at least for a consistent styling. At least in CloudUI we just wrap it into the Link component from NextJS, so the Link from Next provides functionality, and the Link from HIVE provides styling.
If we remove the Link in HVE then we might lose that consistent styling...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants