Stop statically linking binaries when building with Nix. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that statically linking with musl increases our response time under load from (in a very specific benchmark, on my computer) ~10ms to ~30ms per response. This feels like a good enough reason not to statically link the code.
SamirTalwar
requested review from
plcplc,
danieljharvey,
i-am-tom,
soupi and
TheInnerLight
|
Did you get any further information on what the memory impact of this change was? I think we should merge this anyway but it'd be nice to record it. |
danieljharvey
approved these changes
Nov 1, 2023
|
FWIW there doesn't seem to be any meaningful memory impact here. It's hard to tell because it throws off the statistics (virtual memory is hard), but I don't believe we use a noticeably different amount of memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It turns out that statically linking with musl increases our response time under load from (in a very specific benchmark, on my computer) ~10ms to ~30ms per response. Disabling static linking fixes this issue, bringing ndc-postgres in line with HGE v2.
This feels like a good enough reason not to statically link the code.
We ship the Docker image built with Nix, so this directly impacts production. It also simplifies development (in theory) because
nix buildandcargo buildnow have behavior that is more similar.How
I deleted the Nix code that turns on static linking.