move postgres tests to other-db-tests (#108)

### What

We'd like to have all of the tests in the same place. This also helps
with compilation time.

### How

- Copy citus
- Fill in missing tests and make sure all snapshots are renames
- Remove ndc-postgres/tests
- Fix references

.github/test-configuration.json

@@ -1,58 +1,58 @@
 {
   "ndc-postgres-citus": {
-    "package": "ndc-postgres",
+    "feature": "citus",
     "flags": "",
     "services": "citus",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64004"
     }
   },
   "ndc-postgres-cockroach": {
-    "package": "ndc-postgres",
+    "feature": "cockroach",
     "flags": "",
     "services": "cockroach",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64003/defaultdb"
     }
   },
   "ndc-postgres-12": {
-    "package": "ndc-postgres",
-    "flags": "-E 'not test(test_configure)'",
+    "feature": "postgres",
+    "flags": "-E 'not test(configure_initial_configuration_is_unchanged) and not test(configure_is_idempotent)'",
     "services": "postgres",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64002",
       "POSTGRESQL_VERSION": "12"
     }
   },
   "ndc-postgres-13": {
-    "package": "ndc-postgres",
-    "flags": "-E 'not test(test_configure)'",
+    "feature": "postgres",
+    "flags": "-E 'not test(configure_initial_configuration_is_unchanged) and not test(configure_is_idempotent)'",
     "services": "postgres",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64002",
       "POSTGRESQL_VERSION": "13"
     }
   },
   "ndc-postgres-14": {
-    "package": "ndc-postgres",
-    "flags": "-E 'not test(test_configure)'",
+    "feature": "postgres",
+    "flags": "-E 'not test(configure_initial_configuration_is_unchanged) and not test(configure_is_idempotent)'",
     "services": "postgres",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64002",
       "POSTGRESQL_VERSION": "14"
     }
   },
   "ndc-postgres-15": {
-    "package": "ndc-postgres",
-    "flags": "-E 'not test(test_configure)'",
+    "feature": "postgres",
+    "flags": "-E 'not test(configure_initial_configuration_is_unchanged) and not test(configure_is_idempotent)'",
     "services": "postgres",
     "env": {
       "POSTGRESQL_CONNECTION_STRING": "postgresql://postgres:password@localhost:64002",
       "POSTGRESQL_VERSION": "15"
     }
   },
   "ndc-postgres-16": {
-    "package": "ndc-postgres",
+    "feature": "postgres",
     "flags": "",
     "services": "postgres",
     "env": {

.github/workflows/cargo-test.yaml

@@ -82,10 +82,10 @@ jobs:
 
       - name: run tests
         run: |
-          cargo nextest run --no-fail-fast --release -p ${{ env.PACKAGE_NAME }} ${{ env.TEST_FLAGS }}
+          cargo nextest run --no-fail-fast --release -p other-db-tests --features ${{ env.FEATURE_NAME }} ${{ env.TEST_FLAGS }}
         env:
           POSTGRESQL_CONNECTION_STRING: ${{ fromJSON(steps.configuration.outputs.configuration).env.POSTGRESQL_CONNECTION_STRING }}
-          PACKAGE_NAME: ${{ fromJSON(steps.configuration.outputs.configuration).package }}
+          FEATURE_NAME: ${{ fromJSON(steps.configuration.outputs.configuration).feature }}
           TEST_FLAGS: ${{ fromJSON(steps.configuration.outputs.configuration).flags }}
           RUST_LOG: INFO
 
@@ -152,13 +152,14 @@ jobs:
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.BROKEN_BUILD_SLACK_WEBHOOK_URL }}
 
-  test-ndc-postgres-with-yugabyte:
+  test-ndc-postgres-with-database:
     strategy:
       matrix:
         database:
-          - yugabyte
+          - postgres
           - citus
           - cockroach
+          - yugabyte
     name: "test connector (ndc-postgres on ${{ matrix.database }})"
     runs-on: ubuntu-latest
     env:

crates/tests/other-db-tests/Cargo.toml

@@ -16,11 +16,15 @@ yugabyte = []
 cockroach = []
 # We only run the Citus tests if this feature is enabled.
 citus = []
+# We only run the PostgreSQL tests if this feature is enabled.
+postgres = []
 
 [dependencies]
+ndc-postgres = { path = "../../connectors/ndc-postgres" }
 ndc-test = { git = "https://github.com/hasura/ndc-spec.git", tag = "v0.1.0-rc.8" }
 tests-common = { path = "../tests-common" }
 
 axum = "0.6.19"
 insta = { version = "1.34.0", features = ["json"] }
+schemars = { version = "0.8.15", features = ["smol_str", "preserve_order"] }
 tokio = { version = "1.33.0", features = ["full"] }

crates/tests/other-db-tests/src/capabilities_tests.rs

@@ -0,0 +1,7 @@
+#[cfg(test)]
+mod capabilities_tests {
+    #[tokio::test]
+    async fn get_capabilities() {
+        insta::assert_json_snapshot!(ndc_postgres::capabilities::get_capabilities());
+    }
+}

crates/tests/other-db-tests/src/citus/configuration_tests.rs

@@ -8,8 +8,8 @@ mod configuration_tests {
     use tests_common::common_tests;
 
     #[tokio::test]
-    async fn test_configure() {
-        common_tests::configuration_tests::test_configure(
+    async fn test_configure_is_idempotent() {
+        common_tests::configuration_tests::configure_is_idempotent(
             common::CONNECTION_STRING,
             common::CHINOOK_DEPLOYMENT_PATH,
         )

crates/tests/other-db-tests/src/cockroach/configuration_tests.rs

@@ -8,8 +8,8 @@ mod configuration_tests {
     use tests_common::common_tests;
 
     #[tokio::test]
-    async fn test_configure() {
-        common_tests::configuration_tests::test_configure(
+    async fn test_configure_is_idempotent() {
+        common_tests::configuration_tests::configure_is_idempotent(
             common::CONNECTION_STRING,
             common::CHINOOK_DEPLOYMENT_PATH,
         )