Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODE RUB: Clean CreateRandomFileId #397

Open
sulton-max opened this issue Jun 26, 2023 · 1 comment
Open

CODE RUB: Clean CreateRandomFileId #397

sulton-max opened this issue Jun 26, 2023 · 1 comment
Labels
CODE RUB Clean up and align with The Standard

Comments

@sulton-max
Copy link
Contributor

sulton-max commented Jun 26, 2023 •
edited
Loading

Does AI file Id pattern matter ? I mean we don't have validation for that in our foundation layer with AIFileService. But when creating RemoveFileById in orchestration layer, I created this method to create random AI file Id.

Now I think I have overcomplicated it, because that pattern may change anytime and we don't really test it anywhere. So should I remove it and use MnemonicString instead ?

@hassanhabib @ElbekDeveloper

image
@ElbekDeveloper
Copy link
Contributor

Just change the issue name to CODE RUB:

@sulton-max sulton-max changed the title MINOR FIX : AI File Id CODE RUB: Clean CreateRandomFileId Jul 2, 2023
@glhays glhays added the CODE RUB Clean up and align with The Standard label Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CODE RUB Clean up and align with The Standard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glhays @ElbekDeveloper @sulton-max