We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For unit-testing, we need HasClient instance that gives us clientWithRoute, but the instance does not require a RunClient instance.
HasClient
clientWithRoute
RunClient
The easy solution is to write a RunClient instance using undefined, but it would be nicer to keep separate things separate:
undefined
type HasClient m api = (RunClient m, HasClient' m api) class HasClient' m api where ...
... and then require RunClient where necessary in order to implement the HasClient' instance, instead of in the class.
HasClient'
Any concerns or objections? If not I may make a PR.
(ping @pcapriotti)
The text was updated successfully, but these errors were encountered:
the down side i guess is that the constraints will say HasClient, and the instances will be of HasClient'. not entirely pretty.
Sorry, something went wrong.
or we could drop HasClient and always add an explicit RunClient where needed, also where the instance is used?
No branches or pull requests
For unit-testing, we need
HasClient
instance that gives usclientWithRoute
, but the instance does not require aRunClient
instance.The easy solution is to write a
RunClient
instance usingundefined
, but it would be nicer to keep separate things separate:... and then require
RunClient
where necessary in order to implement theHasClient'
instance, instead of in the class.Any concerns or objections? If not I may make a PR.
(ping @pcapriotti)
The text was updated successfully, but these errors were encountered: