From 41ca5b0b254e499fb2faf3ee74b3d3fdfaa492ca Mon Sep 17 00:00:00 2001 From: Jude Allred Date: Tue, 21 Nov 2023 14:26:56 -0500 Subject: [PATCH] repair yarn build/start by fixing a bug in how we passed 'max_old_space_size' --- apps/sim-core/package.json | 2 +- apps/sim-core/packages/core/package.json | 8 ++++---- apps/sim-core/packages/core/vite.config.ts | 4 ++++ apps/sim-core/packages/engine-web/package.json | 4 ++-- apps/sim-core/yarn.lock | 8 ++++---- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/apps/sim-core/package.json b/apps/sim-core/package.json index 2daf380..71f4565 100644 --- a/apps/sim-core/package.json +++ b/apps/sim-core/package.json @@ -104,7 +104,7 @@ "babel-loader": "8.2.1", "babel-plugin-dynamic-import-node": "^2.3.3", "caniuse-lite": "^1.0.30001563", - "cross-env": "7.0.2", + "cross-env": "7.0.3", "eslint": "7.29.0", "eslint-config-prettier": "8.3.0", "eslint-plugin-react-hooks": "4.2.0", diff --git a/apps/sim-core/packages/core/package.json b/apps/sim-core/packages/core/package.json index 7cff97d..69d00aa 100644 --- a/apps/sim-core/packages/core/package.json +++ b/apps/sim-core/packages/core/package.json @@ -9,10 +9,10 @@ "scripts": { "clean": "rimraf dist", "serve": "yarn dev-env vite serve", - "prod-env": "cross-env-shell NODE_OPTIONS=--max_old_space_size=8192 NODE_ENV=production NODE_OPTIONS=--openssl-legacy-provider", - "dev-env": "cross-env-shell NODE_OPTIONS=--max_old_space_size=4096 NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider", + "prod-env": "cross-env-shell NODE_OPTIONS=\"--max_old_space_size=8192 --openssl-legacy-provider\" NODE_ENV=production", + "dev-env": "cross-env-shell NODE_OPTIONS=\"--max_old_space_size=4096 --openssl-legacy-provider\" NODE_ENV=development", "build": "yarn prod-env vite build", - "start": "yarn prod-env vite preview", + "start": "yarn prod-env vite build && vite preview", "fmt": "prettier \"*.{ts,tsx,js,jsx,json,css,scss}\" \"{scripts,src}/**/*.{ts,tsx,js,jsx,json,css,scss}\" --write; eslint --quiet --fix \"*.{ts,tsx,js}\" \"{scripts,src}/**/*.{ts,tsx,js}\"", "fmt-check": "prettier \"*.{ts,tsx,js,jsx,json,css,scss}\" \"{scripts,src}/**/*.{ts,tsx,js,jsx,json,css,scss}\" --check || exit 1; eslint --quiet \"*.{ts,tsx,js}\" \"{scripts,src}/**/*.{ts,tsx,js}\"", "deploy": "ts-node --project scripts/tsconfig.json scripts/deploy.ts", @@ -38,7 +38,7 @@ "/node_modules/(?!monaco-editor).+\\.js$" ] }, - "browserslist": [ + "browserslist": [ "edge >= 88", "firefox >= 78", "chrome >= 87", diff --git a/apps/sim-core/packages/core/vite.config.ts b/apps/sim-core/packages/core/vite.config.ts index 49618c8..c48c8c5 100644 --- a/apps/sim-core/packages/core/vite.config.ts +++ b/apps/sim-core/packages/core/vite.config.ts @@ -37,6 +37,10 @@ export default defineConfig(({ mode }) => { server: { port: 8080, }, + preview: { + port: 8080, + open: true, + }, resolve: { alias: { // Aliases preserved from old webpack config for migration, should investigate removing. diff --git a/apps/sim-core/packages/engine-web/package.json b/apps/sim-core/packages/engine-web/package.json index b86708b..adc4db0 100644 --- a/apps/sim-core/packages/engine-web/package.json +++ b/apps/sim-core/packages/engine-web/package.json @@ -15,8 +15,8 @@ "pretest": "yarn prebuild:node", "test": "jest", "prepare": "npx npm-run-all clean build build:node", - "prod-env": "cross-env-shell NODE_OPTIONS=--max_old_space_size=4096 NODE_ENV=production NODE_OPTIONS=--openssl-legacy-provider", - "dev-env": "cross-env-shell NODE_OPTIONS=--max_old_space_size=4096 NODE_ENV=development NODE_OPTIONS=--openssl-legacy-provider", + "prod-env": "cross-env-shell NODE_OPTIONS=\"--max_old_space_size=4096 --openssl-legacy-provider\" NODE_ENV=production", + "dev-env": "cross-env-shell NODE_OPTIONS=\"--max_old_space_size=4096 --openssl-legacy-provider\" NODE_ENV=development", "build-stdlib": "yarn prod-env webpack --mode production", "build-stdlib-dev": "yarn dev-env webpack --mode development" }, diff --git a/apps/sim-core/yarn.lock b/apps/sim-core/yarn.lock index 68de4c1..3775311 100644 --- a/apps/sim-core/yarn.lock +++ b/apps/sim-core/yarn.lock @@ -4924,10 +4924,10 @@ create-require@^1.1.0: resolved "https://registry.yarnpkg.com/create-require/-/create-require-1.1.1.tgz#c1d7e8f1e5f6cfc9ff65f9cd352d37348756c333" integrity sha512-dcKFX3jn0MpIaXjisoRvexIJVEKzaq7z2rZKxf+MSr9TkdmHmsU4m2lcLojrj/FHl8mk5VxMmYA+ftRkP/3oKQ== -cross-env@7.0.2: - version "7.0.2" - resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.2.tgz#bd5ed31339a93a3418ac4f3ca9ca3403082ae5f9" - integrity sha512-KZP/bMEOJEDCkDQAyRhu3RL2ZO/SUVrxQVI0G3YEQ+OLbRA3c6zgixe8Mq8a/z7+HKlNEjo8oiLUs8iRijY2Rw== +cross-env@7.0.3: + version "7.0.3" + resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-7.0.3.tgz#865264b29677dc015ba8418918965dd232fc54cf" + integrity sha512-+/HKd6EgcQCJGh2PSjZuUitQBQynKor4wrFbRg4DtAgS1aWO+gU52xpH7M9ScGgXSYmAVS9bIJ8EzuaGw0oNAw== dependencies: cross-spawn "^7.0.1"