Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3388: Add version to root package.json #5298

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

CiaranMn
Copy link
Member

@CiaranMn CiaranMn commented Oct 2, 2024

🌟 What is the purpose of this PR?

This PR adds a version field to the repo's root package.json.

This is required in order to be able to add the repo as a submodule in another repo, include it as a yarn workspace in that repo and have the dependencies listed in the package.json be installed – yarn will ignore workspaces that don't have a version listed (fixed in yarn v2, which we haven't migrated to yet).

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Benchmark results

@rust/graph-benches – Integrations

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.2 \mathrm{ms} \pm 355 \mathrm{μs}\left({\color{gray}-0.029 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$48.8 \mathrm{ms} \pm 272 \mathrm{μs}\left({\color{gray}0.182 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$42.2 \mathrm{ms} \pm 171 \mathrm{μs}\left({\color{gray}-0.271 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$66.2 \mathrm{ms} \pm 321 \mathrm{μs}\left({\color{gray}-0.128 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$57.5 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}0.563 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$38.2 \mathrm{ms} \pm 188 \mathrm{μs}\left({\color{gray}0.125 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$92.4 \mathrm{ms} \pm 637 \mathrm{μs}\left({\color{gray}0.508 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.0 \mathrm{ms} \pm 655 \mathrm{μs}\left({\color{gray}0.335 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$77.6 \mathrm{ms} \pm 333 \mathrm{μs}\left({\color{gray}0.280 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$106 \mathrm{ms} \pm 527 \mathrm{μs}\left({\color{gray}0.656 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$96.5 \mathrm{ms} \pm 406 \mathrm{μs}\left({\color{gray}0.284 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$40.8 \mathrm{ms} \pm 220 \mathrm{μs}\left({\color{gray}0.347 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$16.8 \mathrm{ms} \pm 200 \mathrm{μs}\left({\color{gray}2.51 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.6 \mathrm{ms} \pm 179 \mathrm{μs}\left({\color{gray}3.69 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.0 \mathrm{ms} \pm 156 \mathrm{μs}\left({\color{lightgreen}-35.729 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.4 \mathrm{ms} \pm 162 \mathrm{μs}\left({\color{gray}-1.141 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$15.8 \mathrm{ms} \pm 171 \mathrm{μs}\left({\color{lightgreen}-34.520 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$14.8 \mathrm{ms} \pm 178 \mathrm{μs}\left({\color{lightgreen}-6.517 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$15.7 \mathrm{ms} \pm 156 \mathrm{μs}\left({\color{red}19.3 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$15.3 \mathrm{ms} \pm 206 \mathrm{μs}\left({\color{gray}4.53 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$15.6 \mathrm{ms} \pm 157 \mathrm{μs}\left({\color{gray}1.62 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.39 \mathrm{ms} \pm 5.63 \mathrm{μs}\left({\color{gray}-0.809 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.04 \mathrm{ms} \pm 13.8 \mathrm{μs}\left({\color{gray}0.334 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$2.77 \mathrm{ms} \pm 82.5 \mathrm{μs}\left({\color{lightgreen}-7.885 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.89 \mathrm{ms} \pm 7.81 \mathrm{μs}\left({\color{gray}0.487 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.04 \mathrm{ms} \pm 26.2 \mathrm{μs}\left({\color{gray}0.062 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 12.2 \mathrm{μs}\left({\color{gray}0.185 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$45.4 \mathrm{ms} \pm 2.65 \mathrm{ms}\left({\color{red}45.9 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$71.6 \mathrm{ms} \pm 351 \mathrm{μs}\left({\color{gray}1.51 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.8 \mathrm{ms} \pm 237 \mathrm{μs}\left({\color{gray}1.92 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$264 \mathrm{ms} \pm 2.68 \mathrm{ms}\left({\color{lightgreen}-32.553 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.7 \mathrm{ms} \pm 84.7 \mathrm{μs}\left({\color{gray}-0.840 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10000 entities $$12.3 \mathrm{ms} \pm 123 \mathrm{μs}\left({\color{red}39.9 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.84 \mathrm{ms} \pm 4.69 \mathrm{μs}\left({\color{gray}0.703 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.00 \mathrm{ms} \pm 4.90 \mathrm{μs}\left({\color{gray}2.45 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$3.40 \mathrm{ms} \pm 12.4 \mathrm{μs}\left({\color{red}10.4 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.84 \mathrm{ms} \pm 5.05 \mathrm{μs}\left({\color{gray}-0.680 \mathrm{\%}}\right) $$ Flame Graph

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 2, 2024
@CiaranMn CiaranMn added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit 47bbebc Oct 2, 2024
158 of 159 checks passed
@CiaranMn CiaranMn deleted the cm/add-version-to-root-package-json branch October 2, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants