Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pre-built provider generation by skipping code generation if provider version did not change #1832

Closed
ansgarm opened this issue May 31, 2022 · 2 comments
Labels
enhancement New feature or request pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. providers size/medium estimated < 1 week

Comments

@ansgarm
Copy link
Member

ansgarm commented May 31, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Pre-built providers are currently updated via a CRON job that pulls the latest (matching) Terraform provider and generates constructs for its schema. If there's a diff to the current state afterwards a PR is filed (that automerges). If nothing did change, the work is discarded. We should not do all this work (could be ~30mins for large providers) if the provider version did not change.

References

@ansgarm ansgarm added enhancement New feature or request providers needs-priority Issue has not yet been prioritized; this will prompt team review labels May 31, 2022
@DanielMSchmidt DanielMSchmidt added size/medium estimated < 1 week priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Aug 12, 2022
@xiehan xiehan added this to the 0.18 (tentative) milestone Jun 2, 2023
@xiehan xiehan added the pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager label Jun 2, 2023
@ansgarm
Copy link
Member Author

ansgarm commented Jul 13, 2023

This was implemented in cdktf/cdktf-provider-project#255

@ansgarm ansgarm closed this as completed Jul 13, 2023
@xiehan xiehan removed this from the 0.19 (tentative) milestone Jul 13, 2023
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request pre-built providers Issues around pre-built providers managed at https://github.com/hashicorp/cdktf-repository-manager priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. providers size/medium estimated < 1 week
Projects
None yet
Development

No branches or pull requests

3 participants