Add support to enable migrateEncryption option

[jlouisfoster]

Summary

When attempting to add "migrate.encryptionMode" = "required" via configuration_parameters option in .pkr.hcl - this setting does not get added to the .vmx file; thus the change does not occur on the template/vm.

Reproduction Steps

Update configuration_parameters with "migrate.encryptionMode" = "required" and validate if Encrypted vMotion is set to required.

Plugin and Packer version

Packer v1.10.2

Simplified Packer Buildfile

  network_adapters {
    network      = var.vm_network
    network_card = var.network_card
  }

  configuration_parameters = {
    "tools.guest.desktop.autolock" = "FALSE"
    "log.keepOld" = "15"
    "migrate.encryptionMode" = "required"
  }

Operating system and Environment details

Windows Server 2022

Log Fragments and crash.log files

No error in logs

[tenthirtyam]

I believe that this was meant for hashicorp/packer-plugin-vsphere for VMware vSphere where the configuration_parameters is an option.

I'll transfer the issue.

[tenthirtyam]

Try "migrateEncryption" = "required".

[jlouisfoster]

Hi,

Thank you for the quick reply :)

I tried with that option but still no luck...

[tenthirtyam]

No worries. I took a look at the code last night and have an idea why this is not working and a possible fix I plan on testing in my available time next week.

[jlouisfoster]

Thank you!

I really appreciate the support

[tenthirtyam]

Seems that it's one that is ignored by extraConfig.

Similar issue in the sdk.

Ryan

[jlouisfoster]

Hmm so I’m guessing - this is a fix that is needed at the VMware level?

[tenthirtyam]

No, actually if would need to be an enhancement request for this plugin to allow migrateEncryption to be set.

Since migrateEncryption is explicitly configurable through in the ConfigSpec object it is silently ignored when sent in the extraConfig.

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

[tenthirtyam]

Converted to an enhancement.

[jlouisfoster]

Is it possible we can modify the extraconfig via packer?

[tenthirtyam]

Is it possible we can modify the extraconfig via packer?

That's what configuration_parameters allows for but if there is a conflict, it will be ignored.

I submitted the following pull request to add some additional logging and update the docs in that regard.

Take a look at the log output.

#468

[jlouisfoster]

Really appreciate it tenthiryam - sorry for all the questions; it's one of my first enhancement requests.
Will that PR (#468) fix that issue once approved or just provide more logs on how it could be fixed?

[tenthirtyam]

Will that PR fix that issue once approved or just provide more logs on how it could be fixed?

It will just log that the item was ignored and include an update in the docs.

[jlouisfoster]

So the only method is to manually make this change - automating it with packer is not a possibility?

[tenthirtyam]

So the only method is to manually make this change - automating it with packer is not a possibility?

Correct.

Or you could use a provisioner to do this with PowerCLI post build.

[jlouisfoster]

Will look into that, thank you!

[jlouisfoster]

Would you happen to have an example in the docs of setting up a provisioner with powercli for packer?