Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lexer and parser #1

Closed
wants to merge 0 commits into from
Closed

feat: add lexer and parser #1

wants to merge 0 commits into from

Conversation

jimlambrt
Copy link
Collaborator

No description provided.

@github-advanced-security

This comment was marked as outdated.

@jimlambrt jimlambrt force-pushed the jimlambrt-initial branch 4 times, most recently from 1d2de42 to 8a30c68 Compare August 7, 2023 21:40
@github-actions

This comment was marked as outdated.

@jimlambrt jimlambrt force-pushed the jimlambrt-initial branch 3 times, most recently from 4157454 to ce29a26 Compare August 7, 2023 22:15
@jimlambrt jimlambrt marked this pull request as ready for review August 7, 2023 22:17
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@mgaffney mgaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Just some minor requests.

parser.go Outdated Show resolved Hide resolved
parser.go Outdated Show resolved Hide resolved
parser.go Outdated Show resolved Hide resolved
lex.go Outdated Show resolved Hide resolved
expr.go Outdated Show resolved Hide resolved
lex.go Outdated Show resolved Hide resolved
lex.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
@jimlambrt jimlambrt requested a review from mgaffney August 8, 2023 16:44
Copy link
Member

@mgaffney mgaffney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and minor suggestions

docs.go Outdated Show resolved Hide resolved
docs.go Outdated Show resolved Hide resolved
lex.go Outdated Show resolved Hide resolved
parser.go Outdated Show resolved Hide resolved
Copy link

@talanknight talanknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool!

lex.go Outdated Show resolved Hide resolved
lex_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
parser_test.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants