Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support value based label filtering #131

Open
acpana opened this issue Mar 23, 2022 · 0 comments
Open

feat: support value based label filtering #131

acpana opened this issue Mar 23, 2022 · 0 comments

Comments

@acpana
Copy link
Contributor

acpana commented Mar 23, 2022

Overview

Hopefully this is not a "holding it wrong" kinda thing.

Today, go-metrics supports named based label filtering. For instance:

https://github.com/armon/go-metrics/blob/master/metrics_test.go#L465

It'd be useful to support "value" based label filtering. For instance, between two metrics with labels:

notOkLabel := Label{Name: "ok_label", Value: "bad_value"}
okLabel := Label{Name: "ok_label", Value: "good_value"}

not allowing the metric that has a label value equal to bad_value can be useful in cases where I care for some of the label values but not all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant