Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Hostname usage in DogStatsdSink #111

Open
smoya opened this issue Aug 5, 2020 · 0 comments
Open

Deprecate Hostname usage in DogStatsdSink #111

smoya opened this issue Aug 5, 2020 · 0 comments

Comments

@smoya
Copy link

smoya commented Aug 5, 2020

hostname is only being used for pulling it out when matched as metric prefix:
https://github.com/armon/go-metrics/blob/master/datadog/dogstatsd.go#L63-L82

This is not only not documented but also a very unexpected behaviour that has caused us some problems in the past (where are my metrics?) -- See netlify/netlify-commons#140

I can submit a PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant