Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Freeze transaction to use instant in time #79

Open
ljianghedera opened this issue Jul 29, 2021 · 0 comments
Open

Update Freeze transaction to use instant in time #79

ljianghedera opened this issue Jul 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ljianghedera
Copy link
Contributor

ljianghedera commented Jul 29, 2021

Problem

Currently, the freeze transaction is sending startHour, startMin, endHour, endMin to specify that the services should be frozen at startHour and startMin from now, and should wake up at endHour and endMin from now.

Need to change this to use startTime and endTime of Instant to.

Solution

Need to make the following change of the FreezeTransactionBody:

message FreezeTransactionBody {
    int32 startHour = 1 [deprecated = true]; // The start hour (in UTC time), a value between 0 and 23
    int32 startMin = 2 [deprecated = true]; // The start minute (in UTC time), a value between 0 and 59
    int32 endHour = 3 [deprecated = true]; // The end hour (in UTC time), a value between 0 and 23
    int32 endMin = 4 [deprecated = true]; // The end minute (in UTC time), a value between 0 and 59
    FileID updateFile = 5; // The ID of the file needs to be updated during a freeze transaction
    bytes fileHash = 6; // The hash value of the file, used to verify file content before performing freeze and update
    Timestamp startTime = 7; // the freeze start Timestamp
}

Alternatives

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant