Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] It would be nice to support last x days, e.g. '0 0 0 L-3 * *' (3 days to the end of every month) #254

Open
johnnynanjiang opened this issue Dec 20, 2021 · 3 comments

Comments

@johnnynanjiang
Copy link

johnnynanjiang commented Dec 20, 2021

Some other tools support L-3

https://www.freeformatter.com/cron-expression-generator-quartz.html

@johnnynanjiang johnnynanjiang changed the title It would be nice to support last x days, e.g. '0 0 0 L-3 * *' (3 days to the end of every month) [Feature Request] It would be nice to support last x days, e.g. '0 0 0 L-3 * *' (3 days to the end of every month) Dec 20, 2021
@johnnynanjiang
Copy link
Author

Hi @harrisiirak

  1. Do you think it is worthwhile adding support for things like L-3, I checked the code and feel like it would not be a quick change.

  2. I know CRON expressions don't support fortnightly, would you think it is possible to implement it as an extension?

Thanks and regards,
Johnny

@harrisiirak
Copy link
Owner

HI @johnnynanjiang!

I've been trying to keep this library as lean as possible (with some minor deviations) and avoiding adding anything very complex that has impact to code complexity itself, or to the performance (everything has its cost). While L-n (and some other Quartz specific features) looks useful in some cases, greater impact needs to be evaluated. I'm not saying no (by not closing it and tagging this as a feature request) to this but I don't probably have enough any time evaluate the possible implementation myself in the near future.

Extensions (and configurable ones, with an option to switch them on or off) sounds an interesting and intriguing idea, but probably will not scale/work well with current internal implementation. As there has been different wishes (like switching off all non-standard features, only working with some specific features), such extension/feature level approach looks like useful opportunity. This however needs a bit different approach on the code level - something to think in the future.

@johnnynanjiang
Copy link
Author

Thanks @harrisiirak for your detailed response, it makes sense.

We are using your library for our product for now, appreciate the great work. Hopefully we could have some time together to work on these new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants