Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi. Please check the modifications made #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lakshmun
Copy link

@lakshmun lakshmun commented Jul 5, 2012

Changes made to communicate with server for exchange of data.

I have mentioned the details in the file README.txt

Changes made to communicate with server for exchange of data
@hardion
Copy link
Owner

hardion commented Jul 6, 2012

Hi Lakshmun,

Thanks for your job.

That I see firstly is that you create a new Mock with network simulation, isn't it. Maybe you could move your code to a new class.
Secondly, you shouldn't change the MilKInterface unless to give a valuable interaction for the user of the library (openconnection(...) should be private and valuable only for the implementation).

I will do a complete review your code soon.

Have a nice week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants