Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period must be >= 1ms for BCM using Win32 API #1847

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

pierreluctg
Copy link
Collaborator

Using a win32 SetWaitableTimer with a period of 0 means that the timer will only be signaled once. This will make the ThreadBasedCyclicSendTask to only send one message.

https://learn.microsoft.com/en-us/windows/win32/api/synchapi/nf-synchapi-setwaitabletimer

The period of the timer, in milliseconds. If lPeriod is zero, the timer is signaled once. If lPeriod is greater than zero, the timer is periodic. A periodic timer automatically reactivates each time the period elapses, until the timer is canceled using the CancelWaitableTimer function or reset using SetWaitableTimer. If lPeriod is less than zero, the function fails.

…r than 1 ms

Using a win32 SetWaitableTimer with a period of `0` means that the timer will only be signaled once. This will make the `ThreadBasedCyclicSendTask` to only send one message.
@pierreluctg pierreluctg changed the title BCM using WIN32 API cannot handle period smaller than 1 ms Period must be >= 1ms for BCM using Win32 API Aug 29, 2024
@pierreluctg pierreluctg merged commit c712131 into main Aug 29, 2024
58 of 60 checks passed
@pierreluctg pierreluctg deleted the win32-ThreadBasedCyclicSendTask-fix branch August 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants