gs_usb command-line support (and documentation updates and stability fixes) #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zariiii9003
reviewed
Jun 16, 2024
zariiii9003
reviewed
Jun 16, 2024
zariiii9003
reviewed
Jun 16, 2024
v2: updates as per review hardbyte#1790 (review) by @zariiii9003
…an.logger by treating channel like index when all other arguments are missing
…re to pack 64bit host timestamp into gs_usb field)
|
thank you for your review @zariiii9003 . I hope I have addressed all feedback. I have also found a bug in gs_usb on transmit when the timestamp field is set which I have added a fix for here in this most recent version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with these changes it is now possible to use the gs_usb driver with e.g. can.logger from the command line (like many other interfaces) with
python -m can.logger -i gs_usb -c 0 -b 500000also now possible to send CAN frames from applications that set the timestamp field of the python-can can frame object (e.g. scapy)