Support CANdapter extended length arbitration ID #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zariiii9003
reviewed
Mar 30, 2023
NoahMaceri
reviewed
Apr 2, 2023
There was a problem hiding this comment.
@BroderickJack example comment
elif string[0] == "T" or string[0] == "x": # x is an alternative extended message identifier from the CANDapter
There was a problem hiding this comment.
Also in test_slcan.py you can insert this test after line 40 for a test
# Ewert Energy Systems CANDapter specific
self.serial.write(b"x12ABCDEF2AA55\r")
msg = self.bus.recv(TIMEOUT)
self.assertIsNotNone(msg)
self.assertEqual(msg.arbitration_id, 0x12ABCDEF)
self.assertEqual(msg.is_extended_id, True)
self.assertEqual(msg.is_remote_frame, False)
self.assertEqual(msg.dlc, 2)
self.assertSequenceEqual(msg.data, [0xAA, 0x55])
There was a problem hiding this comment.
Got it, thank you!
zariiii9003
reviewed
Apr 3, 2023
|
@BroderickJack can you fix the failing test? |
More efficient check of arbitration ID Co-authored-by: zariiii9003 <[email protected]>
Type fix in slcan test Co-authored-by: zariiii9003 <[email protected]>
zariiii9003
force-pushed
the
feature/candapter_extended_id
branch
from
8f424ce
to
90ab7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Ewert Energy CANdapter extended arbitration ID ASCII identifier of
xfor the slcan interface implementation.Fixes #1506