From 21d75ee2164015e0023b6ec0067eac731c56448b Mon Sep 17 00:00:00 2001 From: Hristo Hristov Date: Tue, 30 Jan 2024 16:25:50 +0200 Subject: [PATCH] [libc++][docs] Add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` (#79963) I got tripped twice after: 7b4622514d232ce5f7110dd8b20d90e81127c467 Let's at least mention these in the `Contributing.rst` doc. --- libcxx/docs/Contributing.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/libcxx/docs/Contributing.rst b/libcxx/docs/Contributing.rst index 3ff8c15a969b0e..596d86ef224490 100644 --- a/libcxx/docs/Contributing.rst +++ b/libcxx/docs/Contributing.rst @@ -162,6 +162,7 @@ sure you don't forget anything: - Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it? - Did you run the ``libcxx-generate-files`` target and verify its output? +- If needed, did you add `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` to the relevant headers? The review process ==================