Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deb Cooley's No Objection on draft-ietf-cose-key-thumbprint-05: (with COMMENT) #100

Open
OR13 opened this issue Aug 6, 2024 · 1 comment

Comments

@OR13
Copy link
Contributor

OR13 commented Aug 6, 2024


COMMENT:

Section 2: If COSE keys are specifically public asymmetric keys and/or
symmetric keys, you could mention that here. It becomes partially apparent
throughout the reading of the draft, but it would be nice if it was up front.

Section 5.3: The second sentence is trivially true. The question is whether a
different kind of key can use the thumbprint algorithm. Perhaps the second
should say, 'Any party in possession of a key that is represented as a COSE
Keys can use...'

Section 5.6, para 4?, last sentence: For error handling: It seems like there
should be a MUST or at least a SHOULD instead of the current 'will need to'.

@selfissued
Copy link
Collaborator

In 5.3, I suggest changing the text from "Keys that are in other formats can be represented as COSE Keys. Any party in possession of COSE Keys can use the COSE Key Thumbprint." to "Keys that are in other formats can be represented as COSE Keys. Any party in possession of those keys can create their corresponding COSE Key representations and use the COSE Key Thumbprint."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants