Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build badge in readme to show the build workflow status instead of test #1443

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Sep 3, 2024

Context

The badge in our readme file shows build: failing because of #1430. It is misleading because the build workflow works fine. It's only the browser tests that are broken.

This PR changes the badge to report the status of the build workflow instead of the test workflow.

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

Copy link

github-actions bot commented Sep 3, 2024

Performance comparison of head (9d4ac52) vs base (67bae9e)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 515.48 | 518.98 | +0.68%
                                      Sheet B | 166.93 | 169.44 | +1.50%
                                      Sheet T | 147.84 | 149.42 | +1.07%
                                Column ranges | 514.89 | 526.32 | +2.22%
Sheet A:  change value, add/remove row/column |  15.33 |  16.03 | +4.57%
 Sheet B: change value, add/remove row/column | 133.09 | 137.52 | +3.33%
                   Column ranges - add column | 158.24 | 162.22 | +2.52%
                Column ranges - without batch | 458.63 | 479.33 | +4.51%
                        Column ranges - batch |  114.8 | 123.21 | +7.33%

@sequba sequba self-assigned this Sep 3, 2024
@sequba sequba added Docs Improvements or additions to documentation Impact: High labels Sep 3, 2024
@sequba sequba merged commit fa09de2 into develop Sep 3, 2024
20 of 22 checks passed
@sequba sequba deleted the feature/update-readme-build-badge branch September 3, 2024 13:40
sequba added a commit that referenced this pull request Sep 4, 2024
…d of test (#1443)

* Update build badge to show the build workflow status instead of test
sequba added a commit that referenced this pull request Sep 4, 2024
* Use Node 20 in all the build/test workflows (#1435)

* Update build badge in readme to show the build workflow status instead of test (#1443)

* Update build badge to show the build workflow status instead of test

* Add build-docs workflow (#1434)

* Add build-docs workflow

* Add environment variables necessary to build the docs with Node 20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Improvements or additions to documentation Impact: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant