Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http handlers for createclaim/sendclaim #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eskimo
Copy link

@eskimo eskimo commented Jul 18, 2023

This adds http handlers for the createclaim/sendclaim rpc methods.

This was made for shakestation so I could select which wallet to create/send claims from without having to rpc selectwallet which could potentially break other scripts that may have been running at the same time.

This adds http handlers for the createclaim/sendclaim rpc methods.

This was made for shakestation so I could select which wallet to create/send claims from without having to rpc selectwallet which could potentially break other scripts that may have been running at the same time.
@eskimo eskimo changed the title Update http.js Add http handlers for createclaim/sendclaim Jul 18, 2023
@coveralls
Copy link

Coverage Status

coverage: 68.609% (-0.02%) from 68.626% when pulling 9faf3ef on eskimo:master into 81bddcd on handshake-org:master.

@nodech
Copy link
Contributor

nodech commented Dec 18, 2023

I think it would be more appropriate if it followed convention for the name related endpoints.

POST /wallet/:id/open - used for creating and sending open
POST /wallet/:id/bid - used for creating and sending bid
etc..

Accepting post data: name for providing name and broadcast - if we want to send right away.
Also test and hs-client wallet update would make this PR complete.

Copy link
Member

@Falci Falci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make lint happy

Comment on lines +1446 to +1447
const name = valid.str('name');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const name = valid.str('name');
const name = valid.str('name');

Comment on lines +1466 to +1467
const name = valid.str('name');

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const name = valid.str('name');
const name = valid.str('name');

@nodech nodech added waiting for the author modifier wallet part of the codebase wallet-http part of the codebase labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for the author modifier wallet part of the codebase wallet-http part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants