Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Tests #3

Open
hammy4815 opened this issue Aug 19, 2023 · 2 comments
Open

Include Tests #3

hammy4815 opened this issue Aug 19, 2023 · 2 comments

Comments

@hammy4815
Copy link
Owner

Tests are needed mainly for:

  1. Assembly of different material cases
  2. Solving and the curl relations

But could also be useful for other features currently being implemented.

@smartalecH
Copy link
Contributor

smartalecH commented Aug 19, 2023

We should test for accuracy and convergence too (rather than just code correctness).

IIRC, the original paper has a few different examples with effective indices, right? We can run the same problem at various resolutions and ensure they converge. (If we ever add subpixel smoothing, we can use the same tests to check).

@smartalecH
Copy link
Contributor

There are a few more good tests here (which will require PML)

https://opg.optica.org/oe/fulltext.cfm?uri=oe-12-25-6165&id=81978

As a first test, it might be good to just use a few examples from Lukas's book (lots of replication already). ie a simple strip and rib waveguide, qTE and qTM, for a couple of different wavelengths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants