Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nginx from docker image. Closes #200 #203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions image/Makefile
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
server_version=7.0.11
maintainer?=seafileltd
image_prefix?=

base_image=seafileltd/base-mc:18.04
base_image_squashed=seafileltd/base-mc:18.04-squashed
pro_base_image=seafileltd/pro-base-mc:18.04
pro_base_image_squashed=seafileltd/pro-base-mc:18.04-squashed
server_image=seafileltd/seafile-mc:$(server_version)
server_image_squashed=seafileltd/seafile-mc:$(server_version)-squashed
pro_server_image=seafileltd/seafile-pro-mc:$(server_version)
pro_server_image_squashed=seafileltd/seafile-pro-mc:$(server_version)-squashed
latest_pro_server_image=seafileltd/seafile-pro-mc:latest
latest_server_image=seafileltd/seafile-mc:latest
base_image=$(maintainer)/$(image_prefix)base-mc:18.04
base_image_squashed=$(maintainer)/$(image_prefix)base-mc:18.04-squashed
pro_base_image=$(maintainer)/$(image_prefix)pro-base-mc:18.04
pro_base_image_squashed=$(maintainer)/$(image_prefix)pro-base-mc:18.04-squashed
server_image=$(maintainer)/$(image_prefix)seafile-mc:$(server_version)
server_image_squashed=$(maintainer)/$(image_prefix)seafile-mc:$(server_version)-squashed
pro_server_image=$(maintainer)/$(image_prefix)seafile-pro-mc:$(server_version)
pro_server_image_squashed=$(maintainer)/$(image_prefix)seafile-pro-mc:$(server_version)-squashed
latest_pro_server_image=$(maintainer)/$(image_prefix)seafile-pro-mc:latest
latest_server_image=$(maintainer)/$(image_prefix)seafile-mc:latest

all:
@echo
Expand All @@ -26,20 +28,20 @@ base:
docker rmi `docker images --filter "dangling=true" -q --no-trunc`

server:
cd seafile && cp -rf ../../scripts ./ && docker build -t $(server_image) .
cd seafile && cp -rf ../../scripts ./ && docker build -t $(server_image) --build-arg base=$(base_image) .
docker-squash --tag $(server_image_squashed) $(server_image) --from-layer=$(base_image)
docker tag $(server_image_squashed) $(server_image)
docker tag $(server_image) $(latest_server_image)
docker rmi `docker images --filter "dangling=true" -q --no-trunc`

pro-base:
cd pro_base && docker build -t $(pro_base_image) .
cd pro_base && docker build -t $(pro_base_image) --build-arg base=$(base_image) .
docker-squash --tag $(pro_base_image_squashed) $(pro_base_image)
docker tag $(pro_base_image_squashed) $(pro_base_image)
docker rmi `docker images --filter "dangling=true" -q --no-trunc`

pro-server:
cd pro_seafile && cp -rf ../../scripts ./ && docker build -t $(pro_server_image) .
cd pro_seafile && cp -rf ../../scripts ./ && docker build -t $(pro_server_image) --build-arg base=$(pro_base_image) .
docker-squash --tag $(pro_server_image_squashed) $(pro_server_image) --from-layer=$(pro_base_image)
docker tag $(pro_server_image_squashed) $(pro_server_image)
docker tag $(pro_server_image) $(latest_pro_server_image)
Expand Down
7 changes: 1 addition & 6 deletions image/base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV UPDATED_AT=20180412 \

CMD ["/sbin/my_init", "--", "bash", "-l"]

RUN apt-get update -qq && apt-get -qq -y install nginx
RUN apt-get update -qq

# Utility tools
RUN apt-get install -qq -y vim htop net-tools psmisc git wget curl
Expand All @@ -26,11 +26,6 @@ RUN pip install -r /tmp/requirements.txt

COPY services /services

RUN mkdir -p /etc/service/nginx && \
rm -f /etc/nginx/sites-enabled/* /etc/nginx/conf.d/* && \
mv /services/nginx.conf /etc/nginx/nginx.conf && \
mv /services/nginx.sh /etc/service/nginx/run

RUN mkdir -p /etc/my_init.d && rm -f /etc/my_init.d/00_regen_ssh_host_keys.sh

RUN rm -rf \
Expand Down
3 changes: 2 additions & 1 deletion image/pro_base/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM seafileltd/base-mc:18.04
ARG base=seafileltd/base-mc:18.04
FROM ${base}

# syslog-ng and syslog-forwarder would mess up the container stdout, not good
# when debugging/upgrading.
Expand Down
6 changes: 4 additions & 2 deletions image/pro_seafile/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM seafileltd/pro-base-mc:18.04
ARG base=seafileltd/pro-base-mc:18.04
FROM ${base}
WORKDIR /opt/seafile

ENV SEAFILE_VERSION=7.0.11 SEAFILE_SERVER=seafile-pro-server
Expand All @@ -17,6 +18,7 @@ ADD scripts/create_data_links.sh /etc/my_init.d/01_create_data_links.sh
COPY scripts /scripts
COPY templates /templates

EXPOSE 80
EXPOSE 8000
EXPOSE 8082

CMD ["/sbin/my_init", "--", "/scripts/start.py"]
8 changes: 5 additions & 3 deletions image/seafile/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
FROM seafileltd/base-mc:18.04
ARG base=seafileltd/base-mc:18.04
FROM ${base}

# For suport set local time zone.
RUN export DEBIAN_FRONTEND=noninteractive && apt-get update && apt-get install tzdata -y
Expand All @@ -7,7 +8,7 @@ WORKDIR /opt/seafile

RUN mkdir -p /etc/my_init.d

ENV SEAFILE_VERSION=7.0.4 SEAFILE_SERVER=seafile-server
ENV SEAFILE_VERSION=7.0.5 SEAFILE_SERVER=seafile-server

RUN mkdir -p /opt/seafile/ && \
curl -sSL -o - https://download.seadrive.org/seafile-server_${SEAFILE_VERSION}_x86-64.tar.gz \
Expand All @@ -21,6 +22,7 @@ ADD scripts/create_data_links.sh /etc/my_init.d/01_create_data_links.sh
COPY scripts /scripts
COPY templates /templates

EXPOSE 80
EXPOSE 8000
EXPOSE 8082

CMD ["/sbin/my_init", "--", "/scripts/start.py"]
4 changes: 4 additions & 0 deletions scripts/bootstrap.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ def init_seafile_server():
# call('''sed -i -e 's/if not mysql_root_passwd/if not mysql_root_passwd and "MYSQL_ROOT_PASSWD" not in os.environ/g' {}'''
# .format(get_script('setup-seafile-mysql.py')))

# Change bind port of gunicorn
call('''sed -i 's/127.0.0.1:8000/0.0.0.0:8000/' {}'''
.format(get_script('setup-seafile-mysql.py')))

# Change the script to disable check MYSQL_USER_HOST
call('''sed -i -e '/def validate_mysql_user_host(self, host)/a \ \ \ \ \ \ \ \ return host' {}'''
.format(get_script('setup-seafile-mysql.py')))
Expand Down
5 changes: 0 additions & 5 deletions scripts/start.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ def main():
if not exists(generated_dir):
os.makedirs(generated_dir)

if is_https():
init_letsencrypt()
generate_local_nginx_conf()
call('nginx -s reload')

wait_for_mysql()
init_seafile_server()

Expand Down