New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider suggesting Requires instead of After in systemd unit files #92

Open

bertvandepoel opened this issue Jul 25, 2022 · 0 comments

Contributor

bertvandepoel commented Jul 25, 2022 •

edited

Loading

I noticed on https://manual.seafile.com/deploy/start_seafile_at_system_bootup/#create-systemd-service-file-etcsystemdsystemseahubservice that a dependency is created for Seahub on Seafile. However, this is done using After instead of Requires. That means that even if starting Seafile fails or hangs, Seahub will still start. I don't think this is intended behaviour. Therefore I would suggest replacing After with Requires for seafile.service in the seahub.service.

On top of that, I would also advice Requires for databases.

There's also a complicated set of arguments concerning the network.target, where perhaps changes would also make sense. More information about that can be found on https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

If you'd like, I can also make a PR if you don't want to make the changes yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment