Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manual/deploy_pro/setup_with_amazon_s3.md does not list required permissions #309

Open
draeath opened this issue Jul 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@draeath
Copy link

draeath commented Jul 23, 2024

This page should describe the required S3 actions, so that we can write an appropriate IAM or Bucket policy instead of having to guess, or grant more permissions than is required for the application to function.

For example, it's obvious that PutObject would be required - but what about other actions like listBucket or ListMultiRegionAccessPoints?

@freeplant
Copy link
Member

I think it is better to grant a general write permission to Seafile.

@draeath
Copy link
Author

draeath commented Jul 23, 2024

I think it is better to grant a general write permission to Seafile.

Excuse me?

I hope the rest of this software isn't written with that sort of frame of mind. That's a very dangerous idea when talking about something intended to be exposed to the internet. Should someone compromize the installation it'll be trivial for them to locate the IAM credentials used for S3 access, so the access granted by those credentials should be as minimal as possible.

For example, said attacker could enable website hosting out of the bucket, change the bucket policy, and use it to serve out a phishing website from inside my S3 bucket.

@freeplant freeplant added the enhancement New feature or request label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants