Fix "Koren Kii Error" links #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TBH the title itself seems confusing too as "Korean Kii" is the name of the homebrew application for removing the "Korean Key" which causes the error 003 brick in the first place. I think I ought to just change the header altogether |
|
also, please dont make commits to other translations, as that will cause conflicts with crowdin. |
hyperupcall
force-pushed
the
hyperupcall-fix-korean-kii-link
branch
from
e6260ba
to
61a18b1
Compare
|
@playerjmr Agreed, if that is the case, then "Korean Key" may not be the best title. I've updated the PR to only change the base markdown files, feel free to merge or close depending on if the title is good |
|
Yeah this is fine for now, The header change is a whole different project I dont want to deal with rn especially since im starting a new job tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When browsing this wonderful site, I noticed that these links were out of date. Didn't notice a
CONTRIBUTING.mdor similar so not exactly sure how project is built (with Crowdin and all, and not many PRs since #117 landed), so I just did a recursive-directory find & replace of the slug. Things linked properly when runningnpm run docs:dev(in addition todocs:buildanddocs:preview). If you prefer a different format / things done differently, I'd be happy to fix things up in accordance