Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1486 - The ability to set a User as Admin on Edit Users Page #1746

Closed
wants to merge 2 commits into from

Conversation

ntrehan
Copy link
Member

@ntrehan ntrehan commented Sep 17, 2024

Fixes #1486

What changes did you make and why did you make them ?

  • Added an "is Admin" Button in the edit users page
  • Set the change as a Patch update to the user model
  • Refactored some existing scss code to remove redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied ![image](https://github.com/user-attachments/assets/305936c4-46e7-4059-8ae7-fcece77530f5)
Visuals after changes are applied

image

@JackHaeg
Copy link
Member

JackHaeg commented Sep 17, 2024

  • @ntrehan Please change "is Admin" button to "VRMS Admin".
  • for @trillium - Also, it may be helpful to be mindful of when we merge this issue. In order for this feature to work properly and be secure, we need to ensure that we have the following feature implemented as well: Implement Super Admin User Feature #1747

@JackHaeg JackHaeg mentioned this pull request Sep 17, 2024
11 tasks
@ntrehan ntrehan closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ability for Admins to promote and demote Admins
2 participants