Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML to MUI in VRMS/client/src/components/admin/reports /index.js #1706

Closed
wants to merge 3 commits into from

Conversation

nora-zajzon
Copy link
Member

@nora-zajzon nora-zajzon commented Jul 25, 2024

Fixes #1679

What changes did you make and why did you make them ?

  • Changed all the HTML components to MUI applicable components
Visuals after changes are applied Screenshot 2024-07-24 at 8 20 02 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-index development
git pull https://github.com/nora-zajzon/VRMS.git index

@trillium
Copy link
Member

trillium commented Aug 5, 2024

Hey @nora-zajzon, I see that you've taken on multiple tickets as we've gone throught he month of July:

Thanks for taking these on!

It looks like each subsequent PR you're making is including the changes from work on the previous issue (this PR contains changes to 4 files). At the moment it is fine, but please do take care to revert to the development branch for each new PR. It helps us keep changes to the application in smaller chunks so that if there's an issue we can roll back changes in smaller amounts.

Planning on reviewing them in the order that they were submitted :)

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nora-zajzon, can you double check your commits locally? I don't see any file changes to client/src/components/admin/reports/index.js in this PR

@nora-zajzon
Copy link
Member Author

@trillium Do you still want me to submit a pr for index even though it is not in the current iteration of the app? I do have it locally so I can

@trillium
Copy link
Member

trillium commented Sep 1, 2024

No, if you'd prefer to pass on it you're welcome to. If you'd like to see it through we'll review and accept it :)

@jbubar
Copy link
Member

jbubar commented Sep 17, 2024

@nora-zajzon is going to take an action on this. she was unsure if it was important

@nora-zajzon
Copy link
Member Author

Closing this PR due to two being open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/admin/reports/index.js
3 participants