Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix failing weak password test #760

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

paulespinosa
Copy link
Member

@paulespinosa paulespinosa commented Aug 22, 2024

Closes #759

What changes did you make?

  • Make admin_controller.remove_user function only attempt to delete a Cognito user when that operation is requested.
  • Formatted the code using yapf.

Rationale behind the changes?

  • A weak password test was failing because this function was throwing an AuthError because the remove_user function was attempting to remove a non-existing user from Cognito.

Testing done for these changes

  • I re-ran tox in a virtual environment

What did you learn or can share that is new?(optional)

  • The authorization/user management code could be redesigned.
  • The API code needs to follow consistent formatting and style.

Copy link
Collaborator

@erikguntner erikguntner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulespinosa! This looks great.

@erikguntner erikguntner merged commit 133a73a into main Aug 23, 2024
2 checks passed
@paulespinosa paulespinosa deleted the 759-fix-failing-weak-password-test branch August 29, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing weak password test on API
2 participants