Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated github action yml file to run-tests-v1.yml and renamed new br… #752

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Updated github action yml file to run-tests-v1.yml and renamed new br… #752

merged 1 commit into from
Aug 20, 2024

Conversation

johnwroge
Copy link
Member

@johnwroge johnwroge commented Aug 16, 2024 •
edited
Loading

Closes #750

What changes did you make?

  • I updated the github workflow folder to include the old run-tests.yml file and renamed to run-tests-v1.yml
  • I renamed the recently updated file to run-tests-v2.yml.old

Rationale behind the changes?

  • The tests being run on the new Github workflow are failing/non functional so the old run tests file needed to be added to prevent this from occuring.

@johnwroge johnwroge self-assigned this Aug 16, 2024
erikguntner
erikguntner approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@erikguntner erikguntner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John! This looks good.

@erikguntner erikguntner merged commit 0324afb into main Aug 20, 2024
1 of 2 checks passed
@erikguntner erikguntner deleted the 750_revert_github_workflow branch August 20, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikguntner erikguntner erikguntner approved these changes

@tylerthome tylerthome Awaiting requested review from tylerthome

@JpadillaCoding JpadillaCoding Awaiting requested review from JpadillaCoding

@paulespinosa paulespinosa Awaiting requested review from paulespinosa

Assignees

@johnwroge johnwroge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert to the original run-tests workflow
2 participants
@johnwroge @erikguntner