Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema validation: The URL property of achievement is optional #355

Closed
McPringle opened this issue Nov 4, 2022 · 1 comment
Closed

Comments

@McPringle
Copy link
Member

The URL property of achievement is optional, but the schema validation requires this property:

[[12](https://github.com/hackergarten/hackergarten.github.io/actions/runs/3393744962/jobs/5641443017#step:4:13):[22](https://github.com/hackergarten/hackergarten.github.io/actions/runs/3393744962/jobs/5641443017#step:4:23):44] Using gulpfile ~/work/hackergarten.github.io/hackergarten.github.io/gulpfile.js
[12:22:44] Starting 'default'...
[12:22:44] Starting 'generate-xml'...
[12:22:44] Starting 'validate-events'...
[12:22:44] ✖ events.json has 1 validation error(s)
[12:22:44]    › Error: Missing required property: url
[12:22:44]      at /5/achievements/3 against schema /items/properties/achievements/items/required/1
[12:22:44] Schema validation failed for 1 file(s) / 1 file(s)
[12:22:44] 'validate-events' errored after 106 ms
[12:22:44] Error in plugin 'gulp-json-schema'
Message:
    There was schema validation error
Details:
    domainEmitter: [object Object]
    domainThrown: false
[12:22:44] 'generate-xml' errored after 108 ms
[12:22:44] 'default' errored after 109 ms

The schema validation should be modified in a way that the URL property of achievement is optional. The URL property a link is still required.

@McPringle
Copy link
Member Author

Fixed with PR #416

@aalmiray aalmiray closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants