Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix admonition #44

Merged
merged 1 commit into from Jul 25, 2018
Merged

fix admonition #44

merged 1 commit into from Jul 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 22, 2018

I fix #28

My environment activate admonition.

@madmas
Copy link
Member

madmas commented Jul 23, 2018

Hi @asdfg0280 , thanks a lot for the PR!
I wanted to try it befire merge, so I pulled your branch and did this:

bildschirmfoto 2018-07-23 um 16 12 39

(did and npm run build and npm start)
The CSS classes are applied nicely, but the icon are not shown - any idea why taht might be the case?

@ghost
Copy link
Author

ghost commented Jul 23, 2018

uh?
My environment is correct to render.
image
I use Dockerfile. If you can use it, try it.

@ghost
Copy link
Author

ghost commented Jul 24, 2018

My friend says your computer did not install emoji font,did it?
So,plz check it.

and,run dockerfile.(Maybe,Docker is correct render.)

@madmas
Copy link
Member

madmas commented Jul 24, 2018

Yes, I agree that obviously, the font is missing or not applied :)
I've tried both a local build and the dockerized version. The same effect, the font is missing.

I can see that https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.cssis loaded in the network tab of my browser debug console and also https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/fonts/fontawesome-webfont.woff2?v=4.7.0
But it's not used then. What OS / browser do you use?

@ghost
Copy link
Author

ghost commented Jul 24, 2018

My computer is win10 / google chrome.
If you want to try some environment, I try it.

@madmas
Copy link
Member

madmas commented Jul 25, 2018

Okay, I sorted it out, there was a issue in my environment:

bildschirmfoto 2018-07-25 um 09 25 35

Now it looks good, thank you :)

@madmas madmas merged commit 0996636 into hackergarten:master Jul 25, 2018
@ghost
Copy link
Author

ghost commented Jul 25, 2018

Oh! That's nice!
By the way, Will I rewrite readme.adoc ?
Cuz' we can render admonition correctly.

@ghost ghost deleted the add/admonition branch July 26, 2018 00:24
@ghost ghost restored the add/admonition branch July 26, 2018 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admonition icons not rendering
2 participants