Site Should Be Able To Render Without External Data

[sampoder]

If the GitHub API goes down, for example, the site should be still be able to load just without the stars or activity showing.

[LassazVegaz]

Since the PR branch has been deleted, I would like to fix this issue.

[maxwofford]

Would also like to flag this is happening for preview deploys sometimes #988 (comment)

[maxwofford]

@LassazVegaz if you can take a crack at this please do! it'd help a bunch

[LassazVegaz]

@maxwofford sure

[LassazVegaz]

@maxwofford I can see some places using process.env.GITHUB_TOKEN to fetch data from GitHub Hackclub org. But they are not surrounded by try-catch. So I think if they fail, the site fails too. I can add try-catch and handle the errors without breaking the site, but I won't be able to test it. Is that okay?

If this is not what you want, please point out the places you want me to check.

[maxwofford]

Shouldn't the result be the same for invalid token and missing token? If we can't pull GH data let's fill those areas on the page with some other placeholder

[LassazVegaz]

When the token is missing, it does not fetch data. If the token is there, it does not check the validity of the token. Just fetch data. Check fetchStars function and its usage here without Try-Catch which can fail the execution of rest of the code.

[grymmy]

@LassazVegaz @maxwofford do we plan on moving forward with this change? seems reasonable, but this issue's also been open over a year