Add setup command to TunInterface #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradev
reviewed
Mar 2, 2024
conradev
approved these changes
Mar 9, 2024
tun/src/tokio/mod.rs
Outdated
| @@ -15,6 +15,11 @@ impl TunInterface { | |||
| Ok(Self { inner: AsyncFd::new(tun)? }) | |||
| } | |||
|
|
|||
| #[instrument] | |||
| pub async fn set_up(&self, up: bool) -> io::Result<()> { | |||
| self.inner.get_ref().set_up(up) | |||
There was a problem hiding this comment.
We should implement set_up on macOS and make it do nothing for now
conradev
requested review from
malted,
JettChenT,
jaspermayone and
Muirrum
as code owners
conradev
force-pushed
the
main
branch
10 times, most recently
from
b937bd9
to
df57cff
Compare
conradev
force-pushed
the
main
branch
7 times, most recently
from
38780ee
to
cb1bc1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.