Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Tracing for Logging #148

Merged
merged 1 commit into from
Sep 2, 2023
Merged

Use Tracing for Logging #148

merged 1 commit into from
Sep 2, 2023

Conversation

JettChenT
Copy link
Member

@JettChenT JettChenT commented Aug 27, 2023 •
edited
Loading

Temporarily creating this pull request to run gh-actions as I don't have push access to #141

@JettChenT JettChenT marked this pull request as draft August 27, 2023 03:10
@JettChenT JettChenT marked this pull request as ready for review August 27, 2023 05:51
@JettChenT JettChenT enabled auto-merge (rebase) August 29, 2023 00:15
@JettChenT
Copy link
Member Author

JettChenT commented Aug 29, 2023 •
edited
Loading

Looks like the new force push to ae9079b reverts the state of the repo back to before the conflicts were merged?
ref: compare

@JettChenT @conradev
Switch logging to use tracing instead of log
c34c4ff 
Tracing has support for intervals and a great os_log integration.
@JettChenT JettChenT merged commit e643d9d into main Sep 2, 2023
9 checks passed
@JettChenT JettChenT deleted the use-tracing branch September 2, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradev conradev conradev approved these changes

@malted malted Awaiting requested review from malted malted is a code owner

@Muirrum Muirrum Awaiting requested review from Muirrum Muirrum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🦔 Burrow
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JettChenT @conradev