Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is $CFG->mod_hvp_export check incorrect? #542

Open
marxjohnson opened this issue Feb 26, 2024 · 0 comments
Open

Is $CFG->mod_hvp_export check incorrect? #542

marxjohnson opened this issue Feb 26, 2024 · 0 comments

Comments

@marxjohnson
Copy link
Contributor

In framework::instance(), there is a line that does $export = !(isset($CFG->mod_hvp_export) && $CFG->mod_hvp_export === '0');

Since $CFG->mod_hvp_export is not documented anywhere, I was wondering if this is meant to be a check on get_config('mod_hvp', 'export') (mod_hvp/export in settings.php), rather than a separate setting that has to be defined manually in config.php?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant