Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Missing ID column when a parent_id was specified, give a nice warning instead of a traceback #855

Closed
pascal-pfeiffer opened this issue Sep 13, 2024 · 3 comments · Fixed by #865
Closed

[UX] Missing ID column when a parent_id was specified, give a nice warning instead of a traceback #855

pascal-pfeiffer opened this issue Sep 13, 2024 · 3 comments · Fixed by #865
Assignees
@us8945
Labels
area/core Core code related issue type/good first issue Good for newcomers

Comments

@pascal-pfeiffer
Copy link
Collaborator

🔧 Proposed code refactoring

Instead of the rather cryptic error below, we should give a nice explanation what is missing in the dataset and how it can be fixed.

image

Motivation

UX
@pascal-pfeiffer pascal-pfeiffer added area/core Core code related issue type/good first issue Good for newcomers labels Sep 13, 2024
@us8945 us8945 mentioned this issue Sep 20, 2024
Merged
@Chubop
Copy link

Chubop commented Oct 21, 2024

@us8945 Is this issue still open for contribution?

@us8945
Copy link
Contributor

us8945 commented Oct 21, 2024

@Chubop , the issue is still in progress. You can see most pending changes in the PR: #865

@us8945
Copy link
Contributor

us8945 commented Oct 22, 2024

Resolved with PR #865

@us8945 us8945 closed this as completed Oct 22, 2024
@pascal-pfeiffer pascal-pfeiffer linked a pull request Oct 23, 2024 that will close this issue
Improve handling of dataset validation for Causal Language Models #865
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@us8945 us8945

Labels
area/core Core code related issue type/good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve handling of dataset validation for Causal Language Models us8945/h2o-llmstudio-fork
3 participants
@pascal-pfeiffer @us8945 @Chubop