Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.8 #141

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Drop support for Python 3.8 #141

merged 7 commits into from
Oct 8, 2024

Conversation

sarayourfriend
Copy link
Collaborator

This PR drops support for Python 3.8, which entered EOL yesterday.

It also completes a few "chores", including:

  • Update development dependencies including pre-commit, pre-commit hooks, and GitHub Actions
  • Fix linting errors (not sure why these weren't failing in CI, but maybe updating pre-commit had something to do with it?)
  • Stop using 204 No Content response types when testing responses that actually include bodies

@sarayourfriend
Drop support for Python 3.8
5064be9
@sarayourfriend
Update GitHub Action versions
3a95ce6
@sarayourfriend
Update and run pre-commit and hooks
4501b23
@sarayourfriend
Do not use No Content status code when testing responses with bodies
a3eb319
@sarayourfriend
Remove redundant function
baffbab 
This kind of string/bytes handling is no longer necessary since pook
v2.0.0 where all bodies are handled as bytes, and converted at the
edges. Internal library functions do not need to handle non-string
bodies.
@sarayourfriend
Update versions of libraries used for testing
eacc6d1
sarayourfriend
sarayourfriend commented Oct 8, 2024
View reviewed changes
History.rst Outdated Show resolved Hide resolved
@sarayourfriend sarayourfriend merged commit 15829a2 into master Oct 8, 2024
7 checks passed
@sarayourfriend sarayourfriend deleted the 3-8-eol branch October 8, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sarayourfriend