Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional stale reference to Google usage #297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

charlesboyd
Copy link
Contributor

Follow up to 5a32e0b.

GWT is no longer used by AdWords.

@niloc132
Copy link
Contributor

niloc132 commented May 4, 2020

Perhaps update it instead to point at gmail, since gmail now has gwt's jre emulation in it?

Last I checked, blogger and groups also still used GWT, are you sure all of these should be removed?

@niloc132
Copy link
Contributor

Confirmed-ish by peeking at the optimized JS that the following definitely still use at least GWT's JRE, if not GWT itself:

  • gmail
  • wallet/pay
  • groups (may be phasing out, haven't confirmed the new one either way, but have had to revert to the old one so that the page still works consistently)
  • sheets
  • app script
  • blogger admin (may be phasing out, haven't confirmed or tried the new one)

It is hard to prove a negative, but we did get confirmation from Google once that AdWords no longer uses GWT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants