New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: WIP restage of memory allocation features #287

Merged

bushidocodes merged 15 commits into master from spec-alignment-2

Dec 16, 2021

Contributor

bushidocodes commented Dec 5, 2021 •

edited

Loading

This PR contains a number of refactors:

Eliminate the "Sandbox Request" and instead modify all global scheduler logic to allocate a "Sandbox" directly.
Begin to decompose parts of a "Sandbox" into objects with OOP-style alloc, init, free methods and associated logic
Cleanup the HTTP Request and Response Logic to use discrete buffers that do not make assumptions about layout.

bushidocodes added 8 commits

December 4, 2021 19:51


          feat: WIP restage of memory allocation features

f4ede43


          fix: debug assorting context switch issues

5e9c7d0


          refactor: Eliminate sandbox request

e888a14


          build: Makefile cleanup

f1e1e85


          fix: correct error handling wasm_stack

22d3890


          refactor: reorder memory_instructions

13b1238


          refactor: mem instructions

332b492


          fix: Corrected assorted bugs

f51da12

bushidocodes commented

View reviewed changes

runtime/src/sandbox_state.c Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/src/libc/syscall.c Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/Makefile Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/compiletime/memory_instructions.c Outdated Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/compiletime/memory_instructions.c Outdated Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/client_socket.h Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/global_request_scheduler.h Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/http.h Show resolved Hide resolved

gparmer approved these changes

View reviewed changes

Collaborator

gparmer left a comment

Don't see any blockers here. Great job. Just some comments throughout.

runtime/compiletime/memory_instructions.c Outdated Show resolved Hide resolved

runtime/compiletime/memory_instructions.c Show resolved Hide resolved

runtime/include/current_sandbox_send_response.h Outdated Show resolved Hide resolved

runtime/include/current_sandbox_send_response.h Show resolved Hide resolved

runtime/include/sandbox_state_history.h Show resolved Hide resolved

runtime/include/wasm_memory.h Show resolved Hide resolved

runtime/include/wasm_stack.h Show resolved Hide resolved

runtime/include/wasm_table.h Show resolved Hide resolved

runtime/src/libc/syscall.c Outdated Show resolved Hide resolved

runtime/src/sandbox.c Outdated Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/sandbox_setup_arguments.h Outdated Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/sandbox_state_history.h Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/scheduler_execute_epoll_loop.h Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/vec_u8.h Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/include/wasm_memory.h Outdated Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/src/global_request_scheduler_deque.c Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/src/global_request_scheduler_deque.c Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/src/module.c Show resolved Hide resolved

bushidocodes commented

View reviewed changes

runtime/src/sandbox.c Outdated Show resolved Hide resolved

bushidocodes added 4 commits

December 9, 2021 16:38


          refactor: Use INLINE macro throughout compiletime

569fdd3


          fix: send_reponse err handling

acff356


          fix: Spell environment correctly

ae48d1a


          refactor: flatten http buffers

4b1f991

bushidocodes added 3 commits

December 10, 2021 19:33


          refactor: wasm_memory

3cf4580


          refactor: wasm_table

57d9538


          refactor: wasm_memory_get_string

452db10

bushidocodes marked this pull request as ready for review

December 16, 2021 02:09

bushidocodes merged commit af016f2 into master

bushidocodes deleted the spec-alignment-2 branch

December 16, 2021 02:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet