Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate cross section #351

Merged
merged 5 commits into from
Jun 17, 2024
Merged

Animate cross section #351

merged 5 commits into from
Jun 17, 2024

Conversation

OnnoEbbens
Copy link
Collaborator

Add method to animate a cross section

Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some items could be made optional, like the colorbar and the title, but that can also be changed later.

It would be great if you can add a small test.

@OnnoEbbens
Copy link
Collaborator Author

Ik zal een voorbeeld toevoegen aan een notebook omdat ik dan alle data heb om een animatie te maken. Ik probeerde dit net maar het lijkt alsof de regis netcdf (tijdelijk) offline is. Ik krijg deze error:

OSError: [Errno -68] NetCDF: I/O failure: b'[http://www.dinodata.nl:80/opendap/REGIS/REGIS.nc](http://www.dinodata.nl/opendap/REGIS/REGIS.nc)'

@OnnoEbbens
Copy link
Collaborator Author

It seems like the old URL works again: https://www.dinodata.nl/opendap/hyrax/REGIS/REGIS.nc

@OnnoEbbens
Copy link
Collaborator Author

I have the feeling that the appropriate URL depends on the package versions I am using. So I did not change anything there

@rubencalje
Copy link
Collaborator

I have the feeling that the appropriate URL depends on the package versions I am using. So I did not change anything there

Strange that it is working in your latest commit, but not in other pull requests after that....

@OnnoEbbens OnnoEbbens merged commit 8fb859b into dev Jun 17, 2024
5 checks passed
@OnnoEbbens OnnoEbbens deleted the animate_cross_section branch June 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants