Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove delr/delc from dataset #343

Closed
1 task done
dbrakenhoff opened this issue May 13, 2024 · 1 comment
Closed
1 task done

Remove delr/delc from dataset #343

dbrakenhoff opened this issue May 13, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dbrakenhoff
Copy link
Collaborator

dbrakenhoff commented May 13, 2024

I propose to remove delr and delc from the dataset entirely. Logic to determine delr/delc will be a separate function that can be called when necessary. Delr and delc are easy to compute from x and y, plus the extent.

The advantage of this change is that caching becomes cleaner (since we don't need to keep track of delr/delc if they are used in the computations for obtaining datasets). It also simplifies code because we don't have to check whether delr/delc are present in either the attributes or data variables.

  • Fix all TODOS related to this, marked with TODO: * delr/delc *
@dbrakenhoff
Copy link
Collaborator Author

Addressed by #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants