Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell exploiter's file copy needs a timeout #3921

Closed
1 task
shreyamalviya opened this issue Dec 1, 2023 · 3 comments
Closed
1 task

PowerShell exploiter's file copy needs a timeout #3921

shreyamalviya opened this issue Dec 1, 2023 · 3 comments
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium

Comments

@shreyamalviya
Copy link
Contributor

Description

PowerShell exploiter's file copy functionality may hang indefinitely.

See agent_2023-11-30_23-47-49_10.2.2.14.log. "ExploiterThread-02" attempts PowerShell on 10.2.2.15 and hangs at the copy file stage (line 1189 of the file). There are no other logs from that thread.

This is racey, and hard to reproduce.

Tasks

  • Add a timeout to the code in the PowerShell exploiter plugin that attempts to copy the file to the victim machine
@shreyamalviya shreyamalviya added Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Impact: Medium Complexity: Low labels Dec 1, 2023
@mssalvatore
Copy link
Collaborator

We have to be careful with file copy timeouts. Networks may be slow and we don't want to prematurely abort an upload.

@shreyamalviya shreyamalviya self-assigned this Dec 13, 2023
@shreyamalviya
Copy link
Contributor Author

jborean93/pypsrp#182

@cakekoa
Copy link
Contributor

cakekoa commented Aug 1, 2024

Moved to guardicode/powershell-exploiter#1

@cakekoa cakekoa closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error, flaw, misbehavior or failure in the Monkey or Monkey Island. Complexity: Low Impact: Medium
Projects
Status: Done
Development

No branches or pull requests

3 participants