-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard-minitest does not seem to work with spring in a Rails 4 engine. #114
Comments
Interesting...I'll need to have a look at how Spring handles engines. |
Doesn't work for me either:
|
@davidmles I was able to get this working, but I need a sanity check. I needed the spring.rb config file pointing to the dummy app along with a change to the spring command. Can you try to run this again, but with config/spring.rb
Guardfile
|
I have a hunch that there is some command gobbling up actual errors instead of raising them, which causes zero tests to be run here and #97. I'd welcome any theories/suggestions/pull requests. |
Not sure if it helps anyone, but with Rails 4.1.6, it seems to work out of the box. I just added My setup: Ruby 2.1, Rails 4.1.6, Guard 2.6.0, guard-minitest 2.3.2, Spring 1.1.3, minitest 5.4.2. |
It also seems to be working fine with rails 4.2, ruby 2.1.5, Guard 2.10.5, guard-minitest 2.3.2, spring 1.2.0, and minitest 5.5.0. It might be okay to close this issue now. |
If anyone can create a GH repo reproducing this, I would look into it. |
Just tested this in a Rails engine. Here is GH repo reproducing the problem Versions in use: |
It's because There should be a message in guard-minitest for this. I'll try and cook something up. |
I've released guard-minitest 2.4.2, which shows an error in this scenario (instead of a silent failure). So, I'm closing this. Let me know if there are any other issues. |
@bikramwp - thanks so much for the repo to reproduce this. I wouldn't have worked this out without it. |
@e2 Good find and good fix. Thanks for picking this one back up. |
@genericsteele - I don't know if Errno::ENOENT is a good choice. But it was the least confusing that I could think of. |
For some reason this issue occurs if there is |
Guard-minitest does not seem to work with spring in a Rails 4 engine.
Steps to reproduce it:
Here it runs the test/example_test.rb sample test successfully:
Now when editing Guardfile and changing
guard :minitest do
toguard :minitest, spring: true do
, the test is not run anymore:Nothing is run.
...does not help either.
The text was updated successfully, but these errors were encountered: