Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Language Highlight Groups #193

Closed
rbong opened this issue Sep 17, 2023 · 1 comment
Closed

Review Language Highlight Groups #193

rbong opened this issue Sep 17, 2023 · 1 comment

Comments

@rbong
Copy link

rbong commented Sep 17, 2023

Languages have been very inconsistent in the past.

  • Either blue identifiers or white identifiers
  • Either green functions or white functions
  • Either orange brackets, white brackets, or grey brackets

We do have generic highlight groups, but they're not used.

TreeSitter uses more consistent colors, with different colors for brackets, variables, functions, and special characters.

We should review languages to make sure they're consistent, and potentially remove custom language groups if they're no longer required.

@rbong
Copy link
Author

rbong commented Sep 19, 2023

Pretty much all languages now use generic highlight groups like Function, Include, Operator, Special, etc.

This really shouldn't be required for a colorscheme, but what can I say? Vim syntax files are a bit of a mess. It's much better than fixing languages by linking them to different colors one-by-one, which is pretty much what we did before.

Languages should look very similar across the board whether you have TreeSitter highlight enabled or have regex highlighting on top of TreeSitter highlighting.

Sorry if anyone doesn't like the new colors, but nothing was done without reason. I hope you will like that you can switch between languages and still know what different colors mean, and that you can customize language colors globally more easily. If you have color settings that you prefer for Gruvbox that are better, please post them here or in a new issue.

This makes new screenshots a priority, see #97

@rbong rbong closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant